Various fixes #65
Closed
Various fixes #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents beforeShow from being called twice, which prevents injectTimepicker from being called twice
…ixes bug I introduced in commit 496ee3a for _onTimeChange)
…od (Fixes Issue 44)
… before date/timepicker has been opened
Owner
|
I pulled from your unstable to my dev the other day and have added some on top of that. I think the only commit since is the bug for 24h format. Since I've make some tweaks to your code I just added that 1 line instead differentiating between your commits and where I've built on top of them. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Trent,
I've been using this version of the timepicker successfully over the last week to try to make sure it's as smooth as possible. I see there's a few more Issues in the tracker, I'll take a look at those soon. In the meantime I hope this adds a bit of stability.
Cheers,
Charles